Typescriptify the ClientFactory #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/ts-client-factory
branch
from
6e5e714 to
1508a27
Compare
jaller94
suggested changes
Aug 4, 2020
There was a problem hiding this comment.
Looking good so far, but you've used any and the current linter config told me not to use it. Are we ok with some explicit anys?
I would be, but of course I would avoid them where possible.
Also, the linter seems to not allow any warnings, which is odd. We should allow warnings, and turn the rules to error if we actually want them to fail CI.
jaller94
reviewed
Aug 4, 2020
| @@ -13,7 +13,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
|
|
|||
| module.exports.ClientFactory = require("./components/client-factory"); | |||
| export * from "./components/client-factory"; | |||
There was a problem hiding this comment.
Do I need to do this for Intent in #185?
There was a problem hiding this comment.
Probably yup, do the tests pass without it?
Co-authored-by: Christian Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.