Conversation
pixlwave
left a comment
pixlwave
left a comment
There was a problem hiding this comment.
I've added a couple of thoughts inline.
schemas/Screen.json
Outdated
| {"const": "Group", "description": "Legacy: The screen that shows information about a specific group."}, | ||
| {"const": "MyGroups", "description": "Legacy: The screen that shows all groups/communities you have joined."}, | ||
|
|
||
| {"const": "MobileLogin", "description": "The screen that displays the login flow."}, |
There was a problem hiding this comment.
I have 2 separate thoughts on this:
- Should it be
MobileAuthenticationif it is meant to cover both login and registration flows? - Or should we rename
WebLogin→LoginandWebRegister→Registerif we want to track the 2 flows separately and use on all platforms?
There was a problem hiding this comment.
WebLogin → Login and WebRegister → Register sounds good to me.
| {"const": "RoomNotifications", "description": "The notifications settings screen shown from the Room Details screen."}, | ||
| {"const": "RoomDirectory", "description": "The screen that lists public rooms for you to discover."}, | ||
| {"const": "StartChat", "description": "The screen shown to create a new (non-direct) room."}, | ||
| {"const": "RoomFilter", "description": "The screen that lists all the user's rooms and let them filter the rooms."}, |
There was a problem hiding this comment.
I'm pretty sure that this isn't the same view as MobileSearchRooms (which may be iOS only anyway) but pointing it out in case it is :)
I only ask as on iOS the rooms are filtered from the Home/MobileFavourites/MobilePeople/MobileRooms tabs so (I don't imagine) we wouldn't track this as a screen there.
There was a problem hiding this comment.
Yes, on Android, rooms can be filtered using a dedicated screen (it will probably change in the future, IA is coming)
|
PR updated. |
pixlwave
left a comment
pixlwave
left a comment
There was a problem hiding this comment.
Looks good to me assuming everything is Ok for Web too.
3 participants
More important screens of the app added.
There are many other screens, do we want to track every single ones?