Fix auth rule 7 implementation on power level check

See matrix-org/matrix-spec#1478
matrix-org · Mar 30, 2023 · 6082107 · 6082107
1 parent 9773e65
commit 6082107
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/models/PowerLevels.ts b/src/models/PowerLevels.ts
@@ -42,7 +42,7 @@ export class PowerLevels {
     }
 
     public canUserSend(userId: string, eventType: string, isState: boolean): boolean {
-        let requiredLevel = isState ? 50 : 0;
+        let requiredLevel = isState ? (this.event ? 50 : 0) : 0;
 
         const defaultLevel = isState ? this.event?.content["state_default"] : this.event?.content["events_default"];
         if (Number.isInteger(defaultLevel)) {

diff --git a/src/server/room_versions/impl/IDMimiLinearized00.ts b/src/server/room_versions/impl/IDMimiLinearized00.ts
@@ -183,10 +183,7 @@ export class IDMimiLinearized00 implements RoomVersion {
             }
         }
 
-        if (
-            powerLevelsEv !== undefined &&
-            !powerLevels.canUserSend(event.sender, event.type, event.state_key !== undefined)
-        ) {
+        if (!powerLevels.canUserSend(event.sender, event.type, event.state_key !== undefined)) {
             throw new Error(`${event.type}: power levels do not permit sending this event`);
         }