Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing ?ts query param #3396

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Fix parsing ?ts query param #3396

merged 1 commit into from
Jul 27, 2024

Conversation

tulir
Copy link
Member

@tulir tulir commented Jul 24, 2024

No description provided.

Signed-off-by: Tulir Asokan <[email protected]>
@tulir tulir requested a review from a team as a code owner July 24, 2024 17:41
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (3e62b98) to head (d742103).

Files Patch % Lines
clientapi/httputil/parse.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3396      +/-   ##
==========================================
- Coverage   67.44%   67.41%   -0.03%     
==========================================
  Files         521      521              
  Lines       47366    47366              
==========================================
- Hits        31946    31932      -14     
- Misses      11422    11433      +11     
- Partials     3998     4001       +3     
Flag Coverage Δ
unittests 52.71% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niebloomj
Copy link

I pulled this and deployed to my server and this fixed all my issues with megabridge! Awesome! Thanks so much @tulir

Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@S7evinK S7evinK merged commit 9566cc6 into matrix-org:main Jul 27, 2024
13 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants