Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event reporting #3340

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Add event reporting #3340

merged 8 commits into from
Mar 21, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 15, 2024

Part of #3216 and #3226

There will be a follow up PR which is going to add the same admin endpoints Synapse has, so existing tools also work for Dendrite.

@S7evinK S7evinK requested a review from a team as a code owner March 15, 2024 21:52
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 70.54264% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (928c8c8) to head (7dd4507).
Report is 1 commits behind head on main.

Files Patch % Lines
clientapi/routing/report_event.go 60.00% 10 Missing and 4 partials ⚠️
roomserver/storage/shared/storage.go 56.25% 7 Missing and 7 partials ⚠️
roomserver/storage/postgres/storage.go 33.33% 2 Missing and 2 partials ⚠️
roomserver/storage/sqlite3/storage.go 33.33% 2 Missing and 2 partials ⚠️
clientapi/routing/routing.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
+ Coverage   67.33%   67.34%   +0.01%     
==========================================
  Files         518      521       +3     
  Lines       46898    47027     +129     
==========================================
+ Hits        31579    31672      +93     
- Misses      11358    11379      +21     
- Partials     3961     3976      +15     
Flag Coverage Δ
unittests 52.57% <70.54%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit b9abbf7 into main Mar 21, 2024
17 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/report-event branch March 21, 2024 18:27
S7evinK added a commit that referenced this pull request Mar 22, 2024
Based on #3340 

This adds a `/_synapse/admin/v1/event_reports` endpoint, the same
Synapse has. This way existing tools also work with Dendrite.
Given this is already getting huge (even though many test lines),
splitting this into two PRs. (The next adds "getting one report" and
"deleting reports")

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant