Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query rooms with ACLs instead of all rooms #3338

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 3, 2024

This now should actually speed up startup times.
This is because many rooms (like DMs) don't have room ACLs, this means that we had around 95% pointless DB queries. (as queried on d.m.org)

@S7evinK S7evinK requested a review from a team as a code owner March 3, 2024 18:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (09f15a3) to head (b9011f7).

❗ Current head b9011f7 differs from pull request most recent head aece4c3. Consider uploading reports for the commit aece4c3 to get more accurate results

Files Patch % Lines
roomserver/storage/shared/storage.go 45.45% 3 Missing and 3 partials ⚠️
roomserver/storage/postgres/events_table.go 71.42% 2 Missing and 2 partials ⚠️
roomserver/storage/sqlite3/events_table.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3338      +/-   ##
==========================================
+ Coverage   67.39%   67.45%   +0.05%     
==========================================
  Files         518      518              
  Lines       46887    46898      +11     
==========================================
+ Hits        31598    31633      +35     
+ Misses      11343    11324      -19     
+ Partials     3946     3941       -5     
Flag Coverage Δ
unittests 52.62% <66.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roomserver/storage/postgres/events_table.go Outdated Show resolved Hide resolved
@S7evinK S7evinK merged commit 928c8c8 into main Mar 5, 2024
16 of 18 checks passed
@S7evinK S7evinK deleted the s7evink/rooms-with-acls branch March 5, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants