Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow + in MIDs as per MSC4009 #3313

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

RosstheRoss
Copy link
Contributor

This PR adds + to the username regex, per MSC4009.

Pull Request Checklist

Signed-off-by: Matt Strapp <[email protected]>

@RosstheRoss
Copy link
Contributor Author

The original version of this PR had a bug where the regex was too loose and would allow some not allowed characters in a range, I added another test so no one else makes the same mistake I did 😅

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d58daf9) 65.29% compared to head (022bb5c) 65.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
- Coverage   65.29%   65.28%   -0.01%     
==========================================
  Files         509      509              
  Lines       57520    57520              
==========================================
- Hits        37557    37552       -5     
- Misses      16058    16061       +3     
- Partials     3905     3907       +2     
Flag Coverage Δ
unittests 50.04% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!
One task down on #3226 :)

@S7evinK S7evinK merged commit a4817f3 into matrix-org:main Jan 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants