Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3987, fix setting Element Android notifications #3242

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Oct 23, 2023

Should fix #3183, since Element Android already implements MSC3987

This is also part of #3225

@S7evinK S7evinK added the spec-compliance Fix something that doesn't comply with the specs label Oct 23, 2023
@S7evinK S7evinK requested a review from a team as a code owner October 23, 2023 14:39
@S7evinK S7evinK mentioned this pull request Oct 23, 2023
16 tasks
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b3adaf) 65.13% compared to head (13da5c3) 65.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3242      +/-   ##
==========================================
+ Coverage   65.13%   65.99%   +0.86%     
==========================================
  Files         507      507              
  Lines       57174    57173       -1     
==========================================
+ Hits        37240    37732     +492     
+ Misses      16031    15659     -372     
+ Partials     3903     3782     -121     
Flag Coverage Δ
unittests 49.48% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/pushrules/default_override.go 100.00% <100.00%> (ø)
internal/pushrules/validate.go 100.00% <100.00%> (ø)
userapi/consumers/roomserver.go 71.13% <100.00%> (+0.94%) ⬆️
internal/pushrules/util.go 91.35% <0.00%> (-1.42%) ⬇️

... and 74 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK changed the title Implement MSC3987, fix setting Android Element notifications Implement MSC3987, fix setting Element Android notifications Oct 23, 2023
@S7evinK S7evinK merged commit 1b124fe into main Oct 24, 2023
20 checks passed
@S7evinK S7evinK deleted the s7evink/pushrules branch October 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance Fix something that doesn't comply with the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to change notification setting on clients using Dendrite servers
2 participants