This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
fix(helm): empty storage class in pvcs #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrenix
force-pushed
the
patch-1
branch
2 times, most recently
from
e1f8301
to
3da51c8
Compare
wrenix
changed the title
|
Can you rebase please? Looks like there are quite a few changes which shouldn't be here. |
|
yes, they was there because i rebased on #3182 -> which is part of So i rebased on |
|
@S7evinK do you like to take a look? |
S7evinK
approved these changes
Oct 25, 2023
S7evinK
pushed a commit
that referenced
this pull request
Feb 29, 2024
i believe that `nil` would be false in the if : ```yaml storageClass: ``` is still handled correct. --- In past ( #3191 ), will have the problem with an empty string `""`: ```yaml storageClass: "" ``` --- do you take another look @S7evinK ? Signed-off-by: WrenIX <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3103
not yet tested