Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Use PDU in more places #3072

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Use PDU in more places #3072

merged 2 commits into from
Apr 28, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Apr 28, 2023

No description provided.

@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 28, 2023
@kegsay kegsay requested a review from a team as a code owner April 28, 2023 14:29
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 65.00% and project coverage change: -0.03 ⚠️

Comparison is base (d23d036) 66.57% compared to head (8f35f21) 66.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
- Coverage   66.57%   66.55%   -0.03%     
==========================================
  Files         496      496              
  Lines       53525    53496      -29     
==========================================
- Hits        35634    35603      -31     
+ Misses      14275    14272       -3     
- Partials     3616     3621       +5     
Flag Coverage Δ
unittests 49.20% <65.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
syncapi/routing/getevent.go 44.68% <0.00%> (-2.13%) ⬇️
syncapi/streams/stream_pdu.go 76.47% <21.42%> (+1.94%) ⬆️
clientapi/routing/state.go 81.39% <33.33%> (-0.94%) ⬇️
appservice/consumers/roomserver.go 71.09% <100.00%> (ø)
internal/pushrules/evaluate.go 77.77% <100.00%> (ø)
setup/mscs/msc2836/msc2836.go 42.85% <100.00%> (ø)
syncapi/routing/context.go 77.31% <100.00%> (ø)
syncapi/routing/memberships.go 66.66% <100.00%> (ø)
syncapi/routing/messages.go 69.50% <100.00%> (ø)
syncapi/routing/search.go 78.03% <100.00%> (ø)
... and 2 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kegsay kegsay merged commit 1432743 into main Apr 28, 2023
@kegsay kegsay deleted the kegan/pdu3 branch April 28, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants