This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add key backup tests #3071
Merged
Add key backup tests #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S7evinK
added
spec-compliance
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
+ Coverage 66.57% 66.75% +0.18%
==========================================
Files 496 496
Lines 53525 53491 -34
==========================================
+ Hits 35634 35710 +76
+ Misses 14275 14181 -94
+ Partials 3616 3600 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
Apr 28, 2023
| return nil | ||
| } | ||
| func (a *UserInternalAPI) DeleteKeyBackup(ctx context.Context, userID, version string) (bool, error) { | ||
| return a.DB.DeleteKeyBackup(ctx, userID, version) |
There was a problem hiding this comment.
We've lost validation here. Previous code checked version was not empty.
There was a problem hiding this comment.
This is already handled at the router level, with a missing {version} variable the functions isn't called. Added a test anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also slightly refactors the functions and methods to rely less on the req/res pattern we had for polylith.
Returns
M_WRONG_ROOM_KEYS_VERSIONfor some endpoints as per the spec