Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

refactor: funnel event creation through room versions #3060

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Apr 20, 2023

In preparation of interfacing up the room version value.

In preparation of interfacing up the room version value.
@kegsay kegsay requested a review from a team as a code owner April 20, 2023 16:47
Copy link
Collaborator

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.11 ⚠️

Comparison is base (72285b2) 66.60% compared to head (9449b93) 66.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   66.60%   66.50%   -0.11%     
==========================================
  Files         495      495              
  Lines       53489    53489              
==========================================
- Hits        35626    35571      -55     
- Misses      14209    14247      +38     
- Partials     3654     3671      +17     
Flag Coverage Δ
unittests 47.07% <30.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
federationapi/internal/perform.go 49.00% <0.00%> (-0.34%) ⬇️
federationapi/routing/invite.go 45.69% <0.00%> (-1.33%) ⬇️
federationapi/routing/join.go 54.81% <0.00%> (-0.54%) ⬇️
federationapi/routing/leave.go 44.72% <0.00%> (-0.85%) ⬇️
federationapi/routing/threepid.go 0.00% <0.00%> (ø)
roomserver/internal/input/input_missing.go 68.27% <0.00%> (-0.16%) ⬇️
roomserver/storage/shared/storage.go 67.77% <50.00%> (-0.81%) ⬇️
internal/transactionrequest.go 74.77% <100.00%> (ø)
roomserver/internal/helpers/helpers.go 67.46% <100.00%> (ø)
...oomserver/storage/postgres/state_snapshot_table.go 68.04% <100.00%> (-3.10%) ⬇️

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants