Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Rdanzey/helm-fixes-existing-db-secrets #3033

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

Arkaniad
Copy link
Contributor

@Arkaniad Arkaniad commented Mar 27, 2023

Fixes some Helm templating issues when setting up a deployment with an existing database / signing keys.

  • Allows for .Values.postgresql.enabled: false as long as .Values.global.dendrite_config.database.connection_string is defined
  • Allows for '.Values.signing_key.create: false' if .Values.signing_key.existingSecret is set

Also fixes an error in the template resulting in profiling port not being set correctly:

Error: template: dendrite-meta/charts/dendrite/templates/deployment.yaml:60:35: executing "dendrite-meta/charts/dendrite/templates/deployment.yaml" at <$.Values.global.profiling.port>: nil pointer evaluating interface {}.port

Pull Request Checklist

Signed-off-by: Rhea Danzey [email protected]

….signing_key.create is false (use existing key)

Signed-off-by: Rhea Danzey <[email protected]>
…onnection string is defined

Signed-off-by: Rhea Danzey <[email protected]>
Signed-off-by: Rhea Danzey <[email protected]>
@S7evinK S7evinK merged commit 28d3e29 into main Mar 28, 2023
@S7evinK S7evinK deleted the rdanzey/helm-fixes-existing-db-secrets branch March 28, 2023 06:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants