-
-
Notifications
You must be signed in to change notification settings - Fork 676
Conversation
388886d
to
5b22bf2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 66.75% 66.60% -0.15%
==========================================
Files 495 495
Lines 53532 53548 +16
==========================================
- Hits 35736 35668 -68
- Misses 14197 14263 +66
- Partials 3599 3617 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
is it possible to review this branch as I need to rebase every few days now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a few more tests to check that we can connect to an appservice using unix sockets.
Probably TestAppserviceInternalAPI
can be copied and changed to listen on a unix socket instead of a HTTP server.
Otherwise looks sane to me.
@S7evinK could you check please? |
can someone check this? |
Thanks for this! |
Thank you very much for the great support! |
This is the last part of unix socket support to talk to app servers, go based app services already support unix sockets:
mautrix/go@5a68173
Pull Request Checklist
Signed-off-by:
Boris Rybalkin <[email protected]>