This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 672
Use /admin/v1/register
in create-account
#2484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like this make me wonder whether we should turn user creation into an admin endpoint instead of having |
CompleteSync
/admin/v1/register
in create-account
@neilalexander , i understand you position. So we should use the same function (of creating accounts) for cmd and URL-Endpoint, without going over the Endpoint ... to prevent missing to create data in the database (for notification or something else). |
…rdUpdate` to invalidate sessions
How do I fix accounts created with |
This was referenced Nov 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
create-account
utility is updated to use the existing/_synapse/admin/v1/register
endpoint, similar toregister_new_matrix_user
on Synapse. This ensures all needed functions are called to propagate e.g. account data.Unfortunately, this means "passwordless" accounts can't be created anymore.
Resetting a password still uses a direct database connection.