Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unsigned.age" field missing from events #1754

Closed
p-e-w opened this issue Feb 6, 2021 · 1 comment
Closed

"unsigned.age" field missing from events #1754

p-e-w opened this issue Feb 6, 2021 · 1 comment

Comments

@p-e-w
Copy link

p-e-w commented Feb 6, 2021

Background information

  • Dendrite version or git SHA: 0.3.9
  • Monolith or Polylith?: Monolith
  • SQLite3 or Postgres?: Postgres
  • Running in Docker?: No
  • go version: 1.15

Description

Synapse -> Synapse

{
  ...
  "origin_server_ts": 1612587703370,
  "unsigned": {
    "age": 4060
  }
}

Dendrite -> Synapse

The age field is missing:

{
  ...
  "origin_server_ts": 1612588027946,
  "unsigned": {}
}

Synapse -> Dendrite

A non-canonical age_ts field is present, which appears to always be equal to origin_server_ts:

{
  ...
  "origin_server_ts": 1612588032002,
  "unsigned": {
    "age_ts": 1612588032002
  }
}

Why this matters

The entire unsigned field is explicitly marked as optional by the spec, but the age subfield is useful for breaking down latency measurements into more fine-grained metrics. This is done by PingPong, which currently cannot break down latencies when Dendrite is involved because of this issue.

@neilalexander
Copy link
Contributor

We've decided to take no action on this at the moment and will revisit if more need arises.

brianathere pushed a commit to HereNotThere/dendrite that referenced this issue Mar 14, 2023
This PR makes the app name an environment variable, allowing us to
determine CORS rules at runtime instead of hardcoding them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants