Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MSC3083 - joining a restricted room. #93

Merged
merged 4 commits into from
Apr 3, 2021

Conversation

clokep
Copy link
Member

@clokep clokep commented Apr 2, 2021

This tests matrix-org/synapse#9735 by creating a room that requires membership of a space to join, then attempts to join it (which will fail), then joins the space, then joins the room (which now succeeds).

@clokep
Copy link
Member Author

clokep commented Apr 2, 2021

i think this probably needs some testing of bad input data and invites.

@clokep clokep requested a review from a team April 2, 2021 16:02
@callahad callahad merged this pull request into master Apr 3, 2021
@callahad
Copy link
Contributor

callahad commented Apr 3, 2021

I accidentally merged this to master here while trying to test out CI on a different origin. My apologies ☹️ Will get sorted out later today / tonight.

@callahad
Copy link
Contributor

callahad commented Apr 3, 2021

(I've reverted master to its previous state, but GitHub still shows this PR as merged despite no longer being in the DAG for origin/master. What a mess 😬)

@clokep
Copy link
Member Author

clokep commented Apr 5, 2021

(I've reverted master to its previous state, but GitHub still shows this PR as merged despite no longer being in the DAG for origin/master. What a mess 😬)

Yeah even reverting it doesn't let you re-open the same PR. I'll make a new one. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants