Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test for https://github.com/element-hq/synapse/issues/16928 #710

Merged
merged 7 commits into from
May 2, 2024
Merged

Regression test for https://github.com/element-hq/synapse/issues/16928 #710

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0f2451
Regression test for https://github.com/element-hq/synapse/issues/16928
kegsay Feb 16, 2024
f08d00d
Update federation_sync_test.go
kegsay Feb 16, 2024
2d7b4f3
Update federation_sync_test.go
kegsay Feb 16, 2024
4ff73a2
Merge branch 'main' into kegan/state-omitted-on-filtered-events
kegsay Feb 16, 2024
f223ad2
Update API shape
kegsay Feb 16, 2024
085ffe1
Skip on Dendrite
kegsay Feb 22, 2024
47d8017
Merge branch 'main' into kegan/state-omitted-on-filtered-events
erikjohnston May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/federation_sync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/matrix-org/complement/helpers"
"github.com/matrix-org/complement/match"
"github.com/matrix-org/complement/must"
"github.com/matrix-org/complement/runtime"
"github.com/tidwall/gjson"
)

Expand All @@ -25,6 +26,7 @@ import (
// - Alice sends event E5 merging the forks.
// - Alice sync with timeline_limit=1 and a filter that skips E5
func TestSyncOmitsStateChangeOnFilteredEvents(t *testing.T) {
runtime.SkipIf(t, runtime.Dendrite) // S2 is put in the timeline, not state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how? does dendrite ignore the limit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, and I don't have the time to diagnose why unfortunately.

deployment := complement.Deploy(t, 1)
defer deployment.Destroy(t)
srv := federation.NewServer(t, deployment,
Expand Down
Loading