Fix flakey test EagerInitialSyncDuringPartialStateJoin
#700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. https://github.com/element-hq/synapse/actions/runs/7423009864/job/20199559386?pr=16782
The flake happened because the test received a PDU during the test clean up, i.e. after we had removed the PDU handler but before the test had finished. During this time a PDU would be received and not handled, resulting in the test being marked as a failure.
The fix is to explicitly wait for the event to be received.
Test output