Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass lazy loading filter to sync reqs in room summary tests #597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fizzadar
Copy link
Contributor

@Fizzadar Fizzadar commented Feb 3, 2023

This aligns correctly with the spec and is also seemingly the only reason the test is disabled on synapse, now re-enabled.

This aligns correctly with the spec and is also seemingly the only reason
the test is disabled on synapse, now re-enabled.
@Fizzadar Fizzadar requested review from a team as code owners February 3, 2023 14:29
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clokep clokep removed the request for review from a team February 7, 2023 00:35
@S7evinK
Copy link
Contributor

S7evinK commented Feb 7, 2023

Also see #553 and matrix-org/matrix-spec#1325, where we came to the conclusion, for now, that it's not clear by the spec when this field should be added.
Looking at RoomSummary and the m.heroes, it states that this is required, if the room has neither m.room.name nor m.room.canonical_alias. So given a room can have neither (e.g. DMs), shouldn't Synapse include a RoomSummary, no matter if lazy loading or not?

@squahtx
Copy link
Contributor

squahtx commented Feb 7, 2023

Also see #553 and matrix-org/matrix-spec#1325, where we came to the conclusion, for now, that it's not clear by the spec when this field should be added. Looking at RoomSummary and the m.heroes, it states that this is required, if the room has neither m.room.name nor m.room.canonical_alias. So given a room can have neither (e.g. DMs), shouldn't Synapse include a RoomSummary, no matter if lazy loading or not?

The spec's a little unclear, since it doesn't directly mention when summary is required. However it makes sense for the server to send m.heroes for DMs, for example. If we take summary to be required when any of its fields are required, then Synapse is not spec compliant here.

I've filed this as matrix-org/synapse#15017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants