Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baby steps for testing leaves during a faster join #581

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Baby steps for testing leaves during a faster join #581

merged 3 commits into from
Jan 12, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Jan 10, 2023 •
edited
Loading

part of matrix-org/synapse#12802

  • Check that leaves work correctly today, even if they block on resync
  • Dummy test that leaves will work before resync completes
  • Ideas for future tests

@DMRobertson DMRobertson marked this pull request as ready for review January 10, 2023 23:32
@DMRobertson DMRobertson requested review from a team as code owners January 10, 2023 23:32
squahtx
squahtx approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Thoroughly logging what the test is doing in human-readable terms is a nice touch.
We've been lax at it when writing the previous tests and as a result it's been painful to understand where they're failing when they go wrong.

@DMRobertson
Copy link
Contributor Author

Thoroughly logging what the test is doing in human-readable terms is a nice touch.
We've been lax at it when writing the previous tests and as a result it's been painful to understand where they're failing when they go wrong.

Glad you like it! (I was writing these as // comments anyway and was finding it painful to keep track when debugging.)

@DMRobertson DMRobertson merged commit db970e4 into main Jan 12, 2023
@DMRobertson DMRobertson deleted the dmr/faster-joins-leave-during-resync branch January 12, 2023 10:29
@DMRobertson DMRobertson mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMRobertson @squahtx