Unskip dendrite skipif on a members presence test #516
Conversation
and able to be ran in isolation
ShadowJonathan
changed the title
|
looks like there are some test failures that need to be fixed? |
|
Fixed, it was a build issue with imports |
This makes the following changes: - get state deltas without the user supplied filter, so we can actually "calculate" state transitions - closes `stmt` when using SQLite - Adds presence for users who newly joined a room, even if the syncing user already knows about the presence status (should fix matrix-org/complement#516)
# Conflicts: # tests/csapi/rooms_members_local_test.go
|
I'm going to re-add the skipif, to unblock this PR, and if matrix-org/dendrite#2803 is fixed, i'll remove the skipif in another PR. |
|
It should be working, once matrix-org/dendrite#2854 is merged |
# Conflicts: # tests/csapi/rooms_members_local_test.go
# Conflicts: # tests/csapi/rooms_members_local_test.go
|
It seems #563 was made before this PR has had any chance to progress. Seeing as how the changes introduced there are antithetical to the actual tests being done (i.e. bob joining a room, and alice seeing bob for the first time, but this being subverted with the addition of an extra pre-existing one-on-one room), I will be reverting that. |
ShadowJonathan
changed the title
DMRobertson
changed the title
|
(CI needs to be re-booped because I only added the signature now, though since it is in code, i'm not sure if it'll go through) |
|
I can see the sign off despite CI not. |
|
Rerunning CI then merging. |
As per matrix-org/dendrite#2803, removes the skipif.
A previous iteration of this PR fixed #515, but #563 already addresses it, noting it here to auto-close it once merged.
Signed-off-by: Jonathan de Jong <[email protected]>