Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster room joins: Add edge case tests for device list tracking #477

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Faster room joins: Add edge case tests for device list tracking #477

merged 1 commit into from
Oct 13, 2022

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Sep 23, 2022 •
edited
Loading

Test device list tracking for users incorrectly thought to be in a
partial state room once the room transitions to full state.

Built on top of #476.

@squahtx squahtx requested review from a team September 23, 2022 18:46
@squahtx
Copy link
Contributor Author

squahtx commented Sep 23, 2022 •
edited
Loading

Expected to pass once matrix-org/synapse#13885 is done,
though this PR contains tests from #475 which will fail until the last bullet in matrix-org/synapse#12993 (comment) is resolved.

@squahtx squahtx mentioned this pull request Sep 23, 2022
Closed
@clokep
Copy link
Member

clokep commented Sep 28, 2022

@squahtx Does this just need Ci kicked (or maybe merge main while you're at it)?

@squahtx
Copy link
Contributor Author

squahtx commented Sep 28, 2022

@squahtx Does this just need Ci kicked (or maybe merge main while you're at it)?

It does, and Rich has already done so.

@squahtx squahtx force-pushed the squah/faster_room_joins_device_list_tracking_incoming_2 branch from c53dda4 to e65bbfd Compare September 29, 2022 13:44
@squahtx squahtx force-pushed the squah/faster_room_joins_device_list_tracking_incoming_3 branch from 865eaab to 363aea6 Compare September 29, 2022 13:44
@erikjohnston erikjohnston merged commit 6606c0a into squah/faster_room_joins_device_list_tracking_incoming_2 Oct 13, 2022
@erikjohnston erikjohnston deleted the squah/faster_room_joins_device_list_tracking_incoming_3 branch October 13, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squahtx @clokep @erikjohnston