Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more thorough tests for device list tracking #459

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Sep 9, 2022

Test what happens when local and remote users join and leave rooms.
The previous test only covered local users already in the same room.

Signed-off-by: Sean Quah [email protected]

Test what happens when local and remote users join and leave rooms.
The previous test only covered local users already in the same room.

Signed-off-by: Sean Quah <[email protected]>
@squahtx
Copy link
Contributor Author

squahtx commented Sep 9, 2022

TestDeviceListUpdates/when_remote_user_leaves_a_room and TestDeviceListUpdates/when_remote_user_rejoins_a_room will fail until matrix-org/synapse#13749 is merged.

...or I create a matching synapse branch with the fixes.

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, just a a few questions in passing

tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants