Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to make sure we can paginate after getting remote event from timestamp to event endpoint #406

Merged

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jul 6, 2022

Add test to make sure we can paginate after getting remote event from timestamp to event endpoint

Synapse changes: matrix-org/synapse#13205

@MadLittleMods MadLittleMods marked this pull request as ready for review July 11, 2022 22:27
@MadLittleMods MadLittleMods requested a review from a team July 11, 2022 22:28
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! I guess this needs to wait for the corresponding Synapse change though before merging?

MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Jul 22, 2022
…ater (#13205)

Depends on #13320

Complement tests: matrix-org/complement#406

We could use the same method to backfill for `/context` as well in the future, see #3848
@MadLittleMods MadLittleMods merged commit 08e9a88 into main Jul 22, 2022
@MadLittleMods MadLittleMods deleted the madlittlemods/msc3030-backfill-at-remote-event-fetched-v2 branch July 22, 2022 21:01
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @DMRobertson and @kegsay 🐁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants