-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3030 Jump to date API endpoint #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSC3030: matrix-org/matrix-spec-proposals#3030 Synapse implementation: matrix-org/synapse#9445
MadLittleMods
commented
Jul 28, 2021
Also as side-effect we also get less flakey tests because it will always pick the event we expect instead of the one behind it because it happened to be created closer to the given timestamp.
MadLittleMods
changed the title
Draft: MSC3030 Jump to date API endpoint
MSC3030 Jump to date API endpoint
Nov 17, 2021
7 tasks
This test does not work because redacted versions of the events are backfilled which include the event_id and origin_server_ts necessary to find it. We just can't see the contents of the message. So it's ok that this test fails. See matrix-org/synapse#9445 (comment)
The history visiblity of the room does not matter. We still return redacted versions of the events regardless of if you can see the event according to the history visiblity.
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Dec 2, 2021
… time of merge Complement tests are in matrix-org/complement#178 but haven't had any review and not sure when they will merge.
…jump-to-date Conflicts: dockerfiles/synapse/homeserver.yaml
4 tasks
Conflicts: dockerfiles/synapse/homeserver.yaml dockerfiles/synapse/workers-shared.yaml
kegsay
reviewed
Mar 2, 2022
kegsay
reviewed
Mar 2, 2022
kegsay
reviewed
Mar 2, 2022
kegsay
approved these changes
Mar 2, 2022
As discovered in #178 (comment)
Thanks for the review @kegsay 🐅 |
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Mar 3, 2022
The Complement tests for MSC3030 are now merged, matrix-org/complement#178 Synapse implmentation: #9445
4 tasks
babolivier
pushed a commit
to matrix-org/synapse
that referenced
this pull request
Mar 3, 2022
The Complement tests for MSC3030 are now merged, matrix-org/complement#178 Synapse implmentation: #9445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to ensure MSC3030 Jump to date functionality
MSC3030: matrix-org/matrix-spec-proposals#3030
Synapse implementation: matrix-org/synapse#9445
Includes nice debug statements when a test fails which give us the full history of messages in the room with color coding to show the expected and actual event alongside where the given timestamp fits into the list of events.
Dev notes
Todo