Test that knocks and invite rejections are sent out correctly over federation #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... useful if you want to receive federation invite requests
richvdh
force-pushed
the
rav/send_leave_federation
branch
from
ee4f87f to
03eb7c0
Compare
richvdh
force-pushed
the
rav/send_leave_federation
branch
from
03eb7c0 to
11b06da
Compare
This was referenced Jun 23, 2021
|
this is failing in GHA because |
kegsay
reviewed
Jun 24, 2021
anoadragon453
approved these changes
Jun 24, 2021
kegsay
reviewed
Jun 25, 2021
There was a problem hiding this comment.
There's a bunch of functions on Event which are generally useful, specifically Sign() and StateKeyEquals() for this PR. For Sign(), the complement server exposes the fields you need
complement/internal/federation/server.go
Line 38 in 63b6c63
This is still the case: matrix-org/synapse#10223 is in Synapse 1.38.0 which is still in RC. I've confirmed the tests pass against 1.38.0rc1. |
|
@anoadragon453 @kegsay thanks for the feedback - PTAL? |
kegsay
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression test for matrix-org/synapse#10222, and also extends the knock tests to ensure we don't do the same thing there.
This needed a bit of groundwork in the test library, as well as requiring that gomatrixserverlib support room v7, so is dependent on matrix-org/gomatrixserverlib#263.