Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: PEP 632 removed distutils #494

Merged
merged 1 commit into from
Nov 29, 2022
Merged

MNT: PEP 632 removed distutils #494

merged 1 commit into from
Nov 29, 2022

Conversation

tacaswell
Copy link
Member

It was only being used for logging.

@tacaswell
MNT: PEP 632 removed distutils
9af42c9 
It was only being used for logging.
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch tacaswell/jupyter-matplotlib/py312_compat

martinRenou
martinRenou approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! These logs were bringing issues when installing the labextension in develop mode anyway, so we should remove them.

@martinRenou
Copy link
Member

CI failures are unrelated. It looks like we are pulling Python 3.11.

@martinRenou martinRenou merged commit a90cf76 into matplotlib:main Nov 29, 2022
@tacaswell tacaswell deleted the py312_compat branch November 29, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tacaswell @martinRenou