Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Test for PHP Version #37

Closed
wants to merge 1 commit into from
Closed

New Test for PHP Version #37

wants to merge 1 commit into from

Conversation

ZerooCool
Copy link
Contributor

New Test for PHP Version

New Test for PHP Version
@tsteur
Copy link
Member

tsteur commented Aug 19, 2019

@ZerooCool could you create a PR for https://github.com/funkatron/phpsecinfo there? If we ever were to update PHPSecInfo, this change would get lost.

It won't get merged though maybe there.

Or did you want to work it and maintain it there and we pull the changes from your repo? I see you have 4 versions listed here: https://github.com/ZerooCool/phpsecinfo

In general as @Findus23 pointed out in #36 (comment) we are maybe already pinging php.net?

$this->current_value = PHP_VERSION;
$url = 'https://php.net/releases/?serialize=1&version=7';
$timeout = self::SOCKET_TIMEOUT;
try {
$latestVersion = Http::sendHttpRequest($url, $timeout);
$versionInfo = safe_unserialize($latestVersion);
$this->recommended_value = $versionInfo['version'];
} catch (Exception $e) {
$this->recommended_value = '';
}
so this PR might not be needed?

@tsteur tsteur mentioned this pull request Aug 19, 2019
@tsteur tsteur closed this Aug 19, 2019
@ZerooCool ZerooCool deleted the patch-2 branch August 20, 2019 23:54
@ZerooCool
Copy link
Contributor Author

I did not understand your request for the PR, but, indeed, I copied the 4 versions of PhpSecInfo on my deposit.

I have finished integrating all the changes of bigdeej (2015) but I have not yet integrated the modifications of funkatron (2012).

Indeed, bigdeej had lost the history of the modifications, but, he worked on the version 0.2.1 and I also chose to start from the version 0.2.1 to be able to identify the contributions.

Now, my version (on the development branch) is a version 3.0.1 (2007 + 2015)

I will integrate the funkatron modifications (2012)
version 3.0.2

I will integrate your improvements again (2016 - 2019)
version 3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants