-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregation of additional action metrics #22348
Conversation
e427762
to
036914f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check implementation of min
.
005db4d
to
3fcf5a5
Compare
...s/PHPUnit/System/expected/test_CustomEvents_eventCategoryOrNameMatch__Events.getName_day.xml
Outdated
Show resolved
Hide resolved
tests/PHPUnit/System/expected/test_DataComparisonTest_flat__Actions.getPageUrls_month.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some values that do not look correct.
...t/System/expected/test_CustomEvents_Events.getCategory_lastN__API.getProcessedReport_day.xml
Outdated
Show resolved
Hide resolved
...HPUnit/System/expected/test_CustomEvents_Events.getName_flat__API.getProcessedReport_day.xml
Outdated
Show resolved
Hide resolved
22748d8
to
732afac
Compare
@sgiehl Edit: This was just a rebase - everything looks good. |
@sgiehl to help me review this, can you explain steps to reproduce. I know in the issue you mentioned it's hard to reproduce in the UI, but can you help me with steps in the API. Also the issue mentions the expected behavior is: |
Description:
Some plugins like PagePerformance or Bandwidth are adding additional metrics to the action reports. Some of those metrics need to be aggregated using min, max or avg aggregation.
As those column aggregation where not correctly set for the datatables, they were by default aggregated by summing the values up. This resulted in incorrect values.
fixes #22350
Review