-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not partial match url params extraction #22281
Open
Lazyuki
wants to merge
8
commits into
matomo-org:5.x-dev
Choose a base branch
from
Lazyuki:fix-url-params-extraction-regex
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: do not partial match url params extraction #22281
Lazyuki
wants to merge
8
commits into
matomo-org:5.x-dev
from
Lazyuki:fix-url-params-extraction-regex
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
reviewed
Jun 6, 2024
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
Tests unrelated to my changes are failing |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix for #16137.
Custom Action Dimensions have an option to automatically extract values from the URL Search Parameters. As mentioned in the docs, it does not allow using Regex because it's supposed to be a "simple" match. One would assume it's doing a simple check to fetch the exact match for the URL parameter.
However, it's actually constructing a partial match with the regex
\?.*pattern=([^&]*)
. This works fine in most cases, but if thepattern
is included in another pattern's word ending, this regex picks that up instead.So imagine trying to extract the
type
parameter from the URLIt should match
type=foo
and returnsfoo
in theory, but current regex actually matchestype=baz
at the end fromcontenttype=baz
because the regex is only searching for a parameter that ends with the specified pattern, in this casetype
. To fix this, we know that valid URLs don't have?
or&
unless they are for search params (as they should be URL encoded otherwise), we can construct the regex[?&]pattern=([^&]*)
instead to make sure the exact pattern is matched in the URL.Review