If the system supplies no nice user-agent, build one. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
commented
Feb 11, 2017
| String model = mBuildInfo.getModel(); | ||
| String build = mBuildInfo.getBuildId(); | ||
| httpAgent = String.format(Locale.US, | ||
| "Dalvik/%s (Linux; U; Android %s; %s Build/%s)", |
There was a problem hiding this comment.
@sgiehl Thoughts on the format? Seems to be the most common Android http agent format.
dotsbb
approved these changes
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I collected ~750k unknown devices, out of those 10% were unknown due to supplying no good user agent.
This PR adds user agent generation if none is available.
The agent is analog to most of the agents I've seen during collection and should hopefully work nicely with piwiks device-detector module.
The other 90% will require regex improvements.
A few popular ones are already covered in matomo-org/device-detector#5586
The rest will require lots of work 😦, see matomo-org/device-detector#5585
Closes #152.