Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds detection for NOOK Browser #7687

Merged
merged 4 commits into from
May 21, 2024
Merged

Adds detection for NOOK Browser #7687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ba28b5
Adds detection for MultiZilla
liviuconcioiu May 17, 2024
0763a68
Adds detection for NOOK Browser
liviuconcioiu May 17, 2024
d99432b
Remove MultiZilla
liviuconcioiu May 21, 2024
16c9c63
Merge branch 'master' into browsers1
liviuconcioiu May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Parser/Client/Browser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ class Browser extends AbstractClientParser
'N2' => 'Norton Private Browser',
'NX' => 'Nox Browser',
'N1' => 'NOMone VR Browser',
'N6' => 'NOOK Browser',
'NE' => 'NetSurf',
'NF' => 'NetFront',
'NL' => 'NetFront Life',
Expand Down Expand Up @@ -761,7 +762,7 @@ class Browser extends AbstractClientParser
'H5', 'V3', 'G2', 'BG', 'OL', 'II', 'TL', 'M6', 'Y3',
'M7', 'GN', 'D3', 'IG', 'HW', '4O', 'OU', '5P', 'KE',
'5A', 'TT', '6P', 'G3', '7P', 'VU', 'F8', 'L4', 'DK',
'DP', 'KL', 'K4',
'DP', 'KL', 'K4', 'N6',
];

/**
Expand Down
9 changes: 9 additions & 0 deletions Tests/Parser/Client/fixtures/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9406,3 +9406,12 @@
engine: ""
engine_version: ""
family: ""
-
user_agent: nook browser/1.0
client:
type: browser
name: NOOK Browser
version: "1.0"
engine: ""
engine_version: ""
family: ""
5 changes: 5 additions & 0 deletions regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
# @license http://www.gnu.org/licenses/lgpl.html LGPL v3 or later
###############

# NOOK Browser
- regex: 'nook browser(?:/(\d+[\.\d]+))?'
name: 'NOOK Browser'
version: '$1'

# Arachne (https://www.glennmcc.org/)
- regex: 'xChaos_Arachne/5\.(\d+\.[\.\d]+)'
name: 'Arachne'
Expand Down
Loading