Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves detection for mobile devices #7665

Merged
merged 8 commits into from
Apr 23, 2024
Merged

Improves detection for mobile devices #7665

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0777bb8
Adds detection for Mintt CoolMintt Tribe
liviuconcioiu Apr 21, 2024
f755e5c
Update model names per convention
liviuconcioiu Apr 21, 2024
8dd56eb
Adds detection for Samsung Galaxy S24
liviuconcioiu Apr 23, 2024
8c72492
Adds detection for Samsung Galaxy S24 Ultra
liviuconcioiu Apr 23, 2024
866ee2e
Improves detection for Samsung Galaxy S24
liviuconcioiu Apr 23, 2024
dc232fb
Adds detection for Kyocera Digno Keitai R
liviuconcioiu Apr 23, 2024
6ae9c08
Merge branch 'master' into devices
liviuconcioiu Apr 23, 2024
d370c5d
Fix regex
liviuconcioiu Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/fixtures/clienthints-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@
device:
type: tablet
brand: Samsung
model: Galaxy Tab A 8.0" WiFi (2019)
model: Galaxy Tab A 8.0" (2019) WiFi
os_family: Android
browser_family: Unknown
-
Expand Down
282 changes: 282 additions & 0 deletions Tests/fixtures/smartphone-38.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6023,3 +6023,285 @@
model: Honor Magic 6 RSR
os_family: Android
browser_family: Unknown
-
user_agent: Mozilla/5.0 (Linux; Android 9; CoolMinttTribe) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.92 Mobile Safari/537.36
os:
name: Android
version: "9"
platform: ""
client:
type: browser
name: Chrome Mobile
version: 77.0.3865.92
engine: Blink
engine_version: 77.0.3865.92
device:
type: smartphone
brand: Mintt
model: CoolMintt Tribe
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; U; Android 14; SM-S9210 Build/UP1A.231005.007) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/100.0.4896.58 UCBrowser/16.4.0.1291 Mobile Safari/537.36
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: UC Browser
version: 16.4.0.1291
engine: Blink
engine_version: 100.0.4896.58
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Unknown
-
user_agent: Mozilla/5.0 (Linux; U; Android 14; SM-S921B Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/121.0.6167.144 Mobile Safari/537.36 OPR/78.0.2254.70362
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Opera Mobile
version: 78.0.2254.70362
engine: Blink
engine_version: 121.0.6167.144
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Opera
-
user_agent: Mozilla/5.0 (Linux; Android 14; SAMSUNG SM-S921W) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/23.0 Chrome/115.0.0.0 Mobile Safari/537.36
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Samsung Browser
version: "23.0"
engine: Blink
engine_version: 115.0.0.0
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Chrome
-
user_agent: Dalvik/2.1.0 (Linux; U; Android 14; SM-S921U Build/UP1A.231005.007)
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Android Browser
version: ""
engine: WebKit
engine_version: ""
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Android Browser
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S921U1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.280 Mobile Safari/537.36 OPR/80.5.4244.78163
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Opera Mobile
version: 80.5.4244.78163
engine: Blink
engine_version: 120.0.6099.280
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Opera
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S921N Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.119 Mobile Safari/537.36 Instagram 324.0.0.27.50 Android (34/14; 420dpi; 1080x2127; samsung; SM-S921N; e1s; s5e9945; ko_KR; 581020724)
os:
name: Android
version: "14"
platform: ""
client:
type: mobile app
name: Instagram App
version: 324.0.0.27.50
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Unknown
-
user_agent: Mozilla/5.0 (Linux; arm_64; Android 14; SM-S9280) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.323 YaSearchBrowser/24.19.1 BroPP/1.0 YaSearchApp/24.19.1 webOmni SA/3 Mobile Safari/537.36
os:
name: Android
version: "14"
platform: ARM
client:
type: browser
name: Yandex Browser
version: 24.19.1
engine: Blink
engine_version: 120.0.6099.323
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (Linux; Android 14; SM-S928U1 Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/123.0.6312.77 Mobile Safari/537.36 [FB_IAB/FB4A;FBAV/457.0.0.54.84;]'
os:
name: Android
version: "14"
platform: ""
client:
type: mobile app
name: Facebook
version: 457.0.0.54.84
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (Linux; Android 14; SM-S928U Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.106 Mobile Safari/537.36[FBAN/EMA;FBLC/en_US;FBAV/396.0.0.9.115;]'
os:
name: Android
version: "14"
platform: ""
client:
type: mobile app
name: Facebook Lite
version: 396.0.0.9.115
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Unknown
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S928N Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.119 Mobile Safari/537.36 Barcelona 323.1.0.35.109 Android (34/14; 420dpi; 1080x2138; samsung; SM-S928N; e3q; qcom; ko_KR; 579136510)
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Chrome Webview
version: 122.0.6261.119
engine: Blink
engine_version: 122.0.6261.119
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S928B Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/124.0.6367.4 Mobile Safari/537.36 Barcelona 323.1.0.35.109 Android (34/14; 600dpi; 1440x2839; samsung; SM-S928B; e3q; qcom; en_IN; 579136510)
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Chrome Webview
version: 124.0.6367.4
engine: Blink
engine_version: 124.0.6367.4
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S928W Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.119 Mobile Safari/537.36 Barcelona 324.0.0.25.109 Android (34/14; 600dpi; 495x1082; samsung; SM-S928W; e3q; qcom; en_CA; 581020806)
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Chrome Webview
version: 122.0.6261.119
engine: Blink
engine_version: 122.0.6261.119
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S928Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.6261.149 Mobile Safari/537.36 OPR/81.5.4292.78980
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Opera Mobile
version: 81.5.4292.78980
engine: Blink
engine_version: 122.0.6261.149
device:
type: smartphone
brand: Samsung
model: Galaxy S24 Ultra
os_family: Android
browser_family: Opera
-
user_agent: Mozilla/5.0 (Linux; Android 14; SM-S921Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.6261.149 Mobile Safari/537.36 OPR/81.5.4292.78980
os:
name: Android
version: "14"
platform: ""
client:
type: browser
name: Opera Mobile
version: 81.5.4292.78980
engine: Blink
engine_version: 122.0.6261.149
device:
type: smartphone
brand: Samsung
model: Galaxy S24
os_family: Android
browser_family: Opera
-
user_agent: Mozilla/5.0 (Linux; Android 10; KY-42C Build/1.050GC.0120.a; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/74.0.3729.136 Mobile Safari/537.36
os:
name: Android
version: "10"
platform: ""
client:
type: browser
name: Chrome Webview
version: 74.0.3729.136
engine: Blink
engine_version: 74.0.3729.136
device:
type: smartphone
brand: Kyocera
model: Digno Keitai R
os_family: Android
browser_family: Chrome
2 changes: 1 addition & 1 deletion Tests/fixtures/smartphone-6.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8745,7 +8745,7 @@
device:
type: smartphone
brand: Huawei
model: Y5 lite
model: Y5 Lite
os_family: Android
browser_family: Chrome
-
Expand Down
2 changes: 1 addition & 1 deletion Tests/fixtures/tablet-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8856,7 +8856,7 @@
device:
type: tablet
brand: Samsung
model: Galaxy Tab A 8.0" LTE (2018)
model: Galaxy Tab A 8.0" (2018) LTE
os_family: Android
browser_family: Chrome
-
Expand Down
Loading
Loading