Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for various apps and improves detection for QQ Browser #7662

Merged
merged 55 commits into from
Apr 24, 2024

Conversation

liviuconcioiu
Copy link
Collaborator

I've also added a generic detection for Electron apps and removed some duplicate user-agents from podcasting.yml. The only difference was the version number.

sanchezzzhak
sanchezzzhak previously approved these changes Apr 23, 2024
@sanchezzzhak sanchezzzhak enabled auto-merge (squash) April 23, 2024 14:29
@sanchezzzhak sanchezzzhak merged commit c49f7e9 into matomo-org:master Apr 24, 2024
15 checks passed
@liviuconcioiu liviuconcioiu deleted the apps branch April 24, 2024 12:53
@Simbiat
Copy link
Contributor

Simbiat commented Apr 27, 2024

Are we sure xmoonvidget and webscraping are actual apps? I am unable to find anything for xmoonvidget, and webscraping is pretty ambiguous by itself to pinpoint some specific app or bot or whatever else.

@liviuconcioiu
Copy link
Collaborator Author

Are we sure xmoonvidget and webscraping are actual apps? I am unable to find anything for xmoonvidget, and webscraping is pretty ambiguous by itself to pinpoint some specific app or bot or whatever else.

I've added them as tests only to detect generic apps based on Electron (3242d73). Those two probably are some private apps, used for web scrapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants