Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, iPadOS, iOS, Lineage OS, macOS #7640

Merged
merged 19 commits into from
Apr 8, 2024

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@liviuconcioiu liviuconcioiu changed the title Adds detection for ElectroBSD and improves detection for Amazon Linux, Chrome OS, Lineage OS Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, Lineage OS Mar 24, 2024
sanchezzzhak
sanchezzzhak previously approved these changes Apr 3, 2024
@liviuconcioiu liviuconcioiu changed the title Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, Lineage OS Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, iOS, Lineage OS, macOS Apr 4, 2024
@liviuconcioiu liviuconcioiu changed the title Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, iOS, Lineage OS, macOS Adds detection for ElectroBSD and improves detection for Amazon Linux, Android, Chrome OS, iPadOS, iOS, Lineage OS, macOS Apr 6, 2024
name: 'iOS'
version: '$1'

- regex: 'Sonos/.+\(ICRU_'
name: 'iOS'
version: ''

- regex: 'CaptiveNetworkSupport|AirPlay'
- regex: 'CaptiveNetworkSupport|AirPlay|.*[ \.\-/]iOS'
Copy link
Collaborator

@sanchezzzhak sanchezzzhak Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.*[ ./-]iOS

EA:
Redundant character escape '.' in RegExp
Inspection info: Reports redundant character escape sequences that can be replaced with unescaped characters preserving the meaning. Many escape sequences that are necessary outside of a character class are redundant inside square brackets [] of a character class.
Although unescaped opening curly braces { outside of character classes are allowed in some dialects (JavaScript, Python, and so on), it can cause confusion and make the pattern less portable, because there are dialects that require escaping curly braces as characters. For this reason the inspection does not report escaped opening curly braces.
Example:
\-\;[\.]
After the quick-fix is applied:
-;[.]

This is not a mistake, we will put everything in order in the future

@sanchezzzhak sanchezzzhak enabled auto-merge (squash) April 8, 2024 07:58
@sanchezzzhak sanchezzzhak merged commit bd9c721 into matomo-org:master Apr 8, 2024
15 checks passed
@liviuconcioiu liviuconcioiu deleted the os branch April 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants