Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blink detection across many browsers. #7583

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

JBYoshi
Copy link
Contributor

@JBYoshi JBYoshi commented Feb 13, 2024

Description:

Lots of Blink-based browsers were being incorrectly detected as WebKit. This PR updates the Blink regex in browser_engines.yml to use a regex that matches on the Chrome/ token for Blink (using versions starting with 29). It also updates several browser definitions that previously referred to WebKit to refer either to Blink or to auto-detect the engine (using an empty string, which appears to be a common thing in the file for some browsers).

Most of the changes in this PR are test cases. I updated them in bulk using this Node.js script. Those should be the only changes in the Tests directory, and can be reproduced by resetting that directory and re-running the script.

Review

@sanchezzzhak sanchezzzhak merged commit 5372aa8 into matomo-org:master Feb 14, 2024
15 checks passed
@JBYoshi JBYoshi deleted the blink-engine branch February 15, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants