Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves detection for Apple devices #7472

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Improves detection for Apple devices #7472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions Tests/fixtures/phablet-1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,3 +1579,67 @@
model: Pova Neo 3
os_family: Android
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_0_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/21A350 [FBAN/FBIOS;FBDV/iPhone15,4;FBMD/iPhone;FBSN/iOS;FBSV/17.0.2;FBSS/3;FBID/phone;FBLC/it_IT;FBOP/5]'
os:
name: iOS
version: 17.0.2
platform: ""
client:
type: mobile app
name: Facebook
version: ""
device:
type: phablet
brand: Apple
model: iPhone 15
os_family: iOS
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_0_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/21A350 [FBAN/FBIOS;FBDV/iPhone15,5;FBMD/iPhone;FBSN/iOS;FBSV/17.0.2;FBSS/3;FBID/phone;FBLC/it_IT;FBOP/5]'
os:
name: iOS
version: 17.0.2
platform: ""
client:
type: mobile app
name: Facebook
version: ""
device:
type: phablet
brand: Apple
model: iPhone 15 Plus
os_family: iOS
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_0_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/21A350 [FBAN/FBIOS;FBDV/iPhone16,1;FBMD/iPhone;FBSN/iOS;FBSV/17.0.2;FBSS/3;FBID/phone;FBLC/it_IT;FBOP/5]'
os:
name: iOS
version: 17.0.2
platform: ""
client:
type: mobile app
name: Facebook
version: ""
device:
type: phablet
brand: Apple
model: iPhone 15 Pro
os_family: iOS
browser_family: Unknown
-
user_agent: 'Mozilla/5.0 (iPhone; CPU iPhone OS 17_0_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/21A350 [FBAN/FBIOS;FBDV/iPhone16,2;FBMD/iPhone;FBSN/iOS;FBSV/17.0.2;FBSS/3;FBID/phone;FBLC/it_IT;FBOP/5]'
os:
name: iOS
version: 17.0.2
platform: ""
client:
type: mobile app
name: Facebook
version: ""
device:
type: phablet
brand: Apple
model: iPhone 15 Pro Max
os_family: iOS
browser_family: Unknown
12 changes: 12 additions & 0 deletions regexes/device/mobiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,6 +1384,18 @@ Apple:
- regex: '(?:MDCR_|ICRU_|Apple-)?iPh(?:one)?14[C,_]7| 14\)$'
model: 'iPhone 14'
device: 'phablet'
- regex: '(?:MDCR_|ICRU_|Apple-)?iPh(?:one)?15[C,_]5| 15PLUS\)$'
model: 'iPhone 15 Plus'
device: 'phablet'
- regex: '(?:MDCR_|ICRU_|Apple-)?iPh(?:one)?16[C,_]1| 15PRO\)$'
model: 'iPhone 15 Pro'
device: 'phablet'
- regex: '(?:MDCR_|ICRU_|Apple-)?iPh(?:one)?16[C,_]2| 15PROMAX\)$'
model: 'iPhone 15 Pro Max'
device: 'phablet'
- regex: '(?:MDCR_|ICRU_|Apple-)?iPh(?:one)?15[C,_]4| 15\)$'
model: 'iPhone 15'
device: 'phablet'

# specific tablet devices
- regex: '(?:MDCR_|ICRU_|Apple-)?iPad1[C,_]1'
Expand Down
Loading