Detect brand and model device for Client-Hints #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
reviewed
Jul 3, 2023
| '(Android 10[.\d]*; K)', | ||
| \sprintf('Android %s; %s', $osVersion, $deviceModel), | ||
| $this->userAgent | ||
| )); |
There was a problem hiding this comment.
In theory it could happen that a device model was provided through the client hints, but the os version is empty. This would in that case end up in a user agent where no version is set at all. Maybe we should keep Android 10 if no version is provided?
There was a problem hiding this comment.
We have rules based on the version + code of the device. I will add a check for the presence of OS
There was a problem hiding this comment.
@sgiehl You can watch this PR again? I made changes.
sgiehl
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these statistics are where the device model is known and the brand is not known from the client-hints.
this fix will help to return the brand and the name of the device.