Fixed version truncation so one client doesn't affect the others #6075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ParserAbstract::$maxMinorParts
is changed by anyClient Parser, it is propagated to all Client Parsers. This
happens because static properties defined ONLY in the parent
class shares a common value with the child class.
To set version truncation specifically for a custom ClientParser, we
need to redefine
ParserAbstract::$maxMinorParts
in the child classand use late static binding to access the property.
Example:
More on late static binding in PHP:
https://www.php.net/manual/en/language.oop5.late-static-bindings.php