-
Notifications
You must be signed in to change notification settings - Fork 92
[DoNotMerge] Demo adding SwaggerUI to documentation #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: live
Are you sure you want to change the base?
Conversation
@snake14 I am not seeing any swagger UI, I ran composer install inside ![]() |
@AltamashShaikh Running The hash in the URL should have scrolled your window. I'm not sure why it didn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snake14 app/openapi/demo_matomo_spec_v1.0.0.json
Would be pulled directly from demo.matomo.cloud
right?
Rest looks good to me, as we are going to update the theming going forward
Good to check, if this doc would be indexed by searchengines or not |
@AltamashShaikh Most likely. This is just a POC. |
@AltamashShaikh I'm guessing it's safe to allow indexing as it looks like the site allows indexing for the latest version: https://github.com/matomo-org/developer-documentation/blob/8dd5f6580b9b7de3dfaf901d14468309e4ab27a1/app/templates/base.twig#L10,L12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates :)
Thank you @james-hill-matomo . I think I might convert this back to draft to make it even more obvious it shouldn't be merged. |
[DoNotMerge]
Description:
This is to demo adding SwaggerUI to the developer documentation. It's using a local JSON OpenAPI spec file for a few plugins. Browse to
/api-reference/reporting-api#openapi-documentation
(if you're using DDEV https://devdocs.ddev.site/api-reference/reporting-api#openapi-documentation) to see the changes.Review