Skip to content

Fixing predictMaskedToken to work with first token masked. Closes #35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwdGitHub merged 1 commit into from
May 25, 2023
Merged

Fixing predictMaskedToken to work with first token masked. Closes #35 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion predictMaskedToken.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

for i = 1:numel(pieces)
tokens = fulltok.tokenize(pieces(i));
if ~isempty(tokens)
if ~isempty(tokens{1})
% "" tokenizes to empty - awkward
x = cat(2,x,fulltok.encode(tokens{1}));
end
Expand Down
7 changes: 5 additions & 2 deletions test/tpredictMaskedToken.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
ValidText = iGetValidText;
end

methods(Test)
methods(Test)
function verifyOutputDimSizes(test, Models, ValidText)
inSize = size(ValidText);
mdl = bert("Model", Models);
Expand Down Expand Up @@ -43,5 +43,8 @@ function inputWithoutMASKRemainsTheSame(test, Models)
validText = struct('StringsAsColumns',manyStrs,...
'StringsAsRows',manyStrs',...
'ManyStrings',repmat(singleStr,3),...
'SingleString',singleStr);
'SingleString',singleStr,...
'FirstWordMasked', "[MASK] the pace.",...
'LastWordMasked', "Accelerating the [MASK].",...
'SingleMaskToken', "[MASK]");
end