Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cmd::to_command public and add docs #94

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

domenicquirl
Copy link

This is intended to increase discoverability of the xshell::Cmd -> std::process::Command conversion, which is already accessible via a From implementation which internally forwards directly to to_command, and be able to document which builder methods translate to the new command and which only apply when executing the xshell version (e.g., quiet obviously doesn't apply, but ignore_status and stdin also don't, since their effects only happen once the command is invoked).

@matklad matklad merged commit fcd8556 into matklad:master Dec 23, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants