Upgrade parking_lot to 0.10 version and use MaybeUninit for it#91
Upgrade parking_lot to 0.10 version and use MaybeUninit for it#91bors[bot] merged 6 commits intomatklad:masterfrom tyranron:upgrade-parking-lot-to-0.10
Conversation
|
While we are at it, it also makes sense to use Line 12 in ea4634c |
Maybe as a separate PR? |
|
It makes sense to do this in the same PR where we bump MSRV, because that's exactly wha allows us ot use maybe uninit |
|
@matklad also, what is the proper way for you to update |
|
Don't know about v1, haven't looked into it yet. In general, it's best to just generate .min.lock using Cargo 1.31 |
|
Hmm... I've used |
|
@matklad I've landed the initial implementation via As I have a little experience dealing with @pitdicker I'll be happy to see your comments too! |
|
@matklad what we have now:
|
|
bors r+ Let's land this now! I think there's a couple of tweaks I want to do, but I've also found an unrelated obscure bug which I'd love to fix, so I do the changes myself |
91: Upgrade parking_lot to 0.10 version and use MaybeUninit for it r=matklad a=tyranron This PR upgrades `parking_lot` dependency to `0.10` version. - [Changelog](https://github.com/Amanieu/parking_lot/blob/0.10.0/CHANGELOG.md#parking_lot-0100-parking_lot_core-070-lock_api-032-2019-11-25) ### Additionally Makes `OnceCell` to use `MaybeUninit` under-the-hood when `parking_lot` feature is enabled ### Checklist - [x] `Cargo.lock.min` updated with `cargo +nightly generate-lockfile -Z minimal-versions` + `cargo lock translate -v1`. - [x] ~~CI job with minimal Rust version `1.36.0` for `parking_lot` feature added~~ - [x] `rustfmt`ed - [x] `CHANGELOG.md` entry added Co-authored-by: tyranron <tyranron@gmail.com>
Build succeeded |
This PR upgrades
parking_lotdependency to0.10version.Additionally
Makes
OnceCellto useMaybeUninitunder-the-hood whenparking_lotfeature is enabledChecklist
Cargo.lock.minupdated withcargo +nightly generate-lockfile -Z minimal-versions+cargo lock translate -v1.CI job with minimal Rust version1.36.0forparking_lotfeature addedrustfmtedCHANGELOG.mdentry added