Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth, core: track block propagation #1078

Merged
merged 12 commits into from
Mar 5, 2024

Conversation

manav2401
Copy link
Contributor

@manav2401 manav2401 commented Nov 8, 2023

Description

This PR tracks multiple timings for block propagation in the network behind a new flag called log.enable-block-tracking which is defaulted to false.

  1. It tracks the delay in block's time and it's actual announcement time i.e. time it starts announcing the block to the network - header.Time (expected block's time)
  2. It tracks delays at the receiving end such as
    • Delay between block first announced and imported (which includes p2p delays, time to fetch and verify headers, and time to fetch block body if any).
    • Delay between block import time and actual block time (header.Time)

It also fixes a bug from upstream (ethereum/go-ethereum#28637) related to tracking time.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: Patch coverage is 60.95238% with 41 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v1.2.7-candidate@32a55dd). Click here to learn what that means.

Files Patch % Lines
eth/fetcher/block_fetcher.go 62.50% 20 Missing and 1 partial ⚠️
eth/backend.go 0.00% 13 Missing ⚠️
eth/handler.go 75.00% 5 Missing ⚠️
eth/protocols/eth/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             v1.2.7-candidate    #1078   +/-   ##
===================================================
  Coverage                    ?   55.97%           
===================================================
  Files                       ?      658           
  Lines                       ?   114478           
  Branches                    ?        0           
===================================================
  Hits                        ?    64082           
  Misses                      ?    46556           
  Partials                    ?     3840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manav2401 manav2401 changed the base branch from v1.1.0-beta-candidate to develop January 17, 2024 04:22
@manav2401 manav2401 changed the base branch from develop to v1.2.6-beta-candidate March 4, 2024 19:11
@manav2401 manav2401 marked this pull request as ready for review March 5, 2024 08:29
@manav2401 manav2401 requested a review from a team March 5, 2024 08:29
@manav2401 manav2401 changed the base branch from v1.2.6-beta-candidate to v1.2.7-candidate March 5, 2024 09:46
@manav2401 manav2401 merged commit cb23b9b into v1.2.7-candidate Mar 5, 2024
11 of 12 checks passed
@manav2401 manav2401 deleted the measure-block-propagation branch March 5, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants