[cleanup] Remove internally deprecated default class not used #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All this does is waste memory on the license-maven-plugin-fs test that uses it. The adjustProperties fails to use what it created there so that just goes to GC. The deprecated method only returns Collections.emptyMap(). Due to test in the license-maven-plugin-fs, keep these as default but have them do nothing as that is what they are actually doing. The adjustProperties will remain to send back emptyMap()
mathieucarbou
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this does is waste memory on the license-maven-plugin-fs test that uses it. Everything else uses defined properties via providers. There is no instance that a missing provider would have even had this data in fact used. So its unnecessary.
The adjustProperties fails to use what it created there so that just goes to GC.
The deprecated method only returns Collections.emptyMap().
Due to test in the license-maven-plugin-fs, keep these as default but have them do nothing as that is what they are actually doing. The adjustProperties will remain to send back emptyMap().
The close() is in fact used earlier on in main code in that it removes the IOException as none exist in all its use-cases which makes the functional usage not have to deal with non thrown exception.
Net result, no real change. Build is effectively the same, code usage would be same, the removed deprecated item isn't used in the code base and was not public to the maven plugin in that context.