Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[actions] Add drop to jdk 8 and maven 3.2.5 to run integration tests after initial build completion #582

Merged
merged 1 commit into from
May 30, 2023
Merged

[actions] Add drop to jdk 8 and maven 3.2.5 to run integration tests after initial build completion #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,19 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up JDK
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.java }}
distribution: ${{ matrix.distribution }}
- name: Test with Maven
- name: Test with Maven Using Project Maven Wrapper
run: ./mvnw clean install site -V -B -D"maven.artifact.threads=64" -D"org.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
- name: Set up JDK 8 Integration Run (Consumer Run)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the second task will build and not re-use the previously workspace from the first task right ?

So if we have this additionnel task that is building and running with mv n3.2.5 / java 8, why do we need to keep the jdl 8 in the matrix above ?

uses: actions/setup-java@v3
with:
java-version: 8
distribution: ${{ matrix.distribution }}
- name: Load Maven 3.2.5 Integration Run (Consumer Run) using GitHub Provided Maven
run: mvn org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -V -B -D"maven=3.2.5"
- name: Test with Maven 3.2.5 Java 8 (Consumer Run)
run: ./mvnw invoker:run -V -B -D"maven.artifact.threads=64" -D"org.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ nb-configuration.xml
# OSX
.DS_Store
release-pom.xml
.mvn/wrapper/maven-wrapper.jar