refactor: Use Maven Integration Test framework to run some integration tests. #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-simons Merged your other PR, can you rebase this one? |
|
@michael-simons Nice find on that IT test logic from maven. I was unaware of that coming into existense. That will be useful on other projects I maintain :) |
|
Sure. I’ll take care of the rebase. I’m pretty sure @khmarbaise will be pleased to hear this. |
…n tests. This makes the `MavenProjectLicensesIT` actually run during verification. The testing framework by Karl Heinz Marbaise takes care of resource copying and filtering and also manual verifcation can be simplified. The biggest advantage of this approach is not having to locally install snapshot variants all the time and a streamlined process. Debugging is still possible (see link in the JavaDoc) via remote debugger.
michael-simons
force-pushed
the
issue/it-tests-arent-used
branch
from
ccfafe7
to
6541e6d
Compare
|
Rebased and green. Thanks for including it and moving the project forward. I really like your approach of this topic*), thank you. *) header and simple yet "good enough" license check |
tanks! still 5 pending checks ;-) there's a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a full reasoning of this PR please have a look at the commit message of ccfafe7. This PR is based on PR #473 and contains ac9a205 from that PR.
In short: The changes makes
MavenProjectLIncensesITrun proper and delegates all the resource copying to the Maven Integration test framework.ProjectBuildingRequestbeing used.