Restore test runs, add jacoco, and fix resulting broken tests #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves shortcoming in junit 5 migration. I had initially wrote that code months ago and coming back to it only ran on command line. Outside of missing import changes in a few spots at that time, it appeared my work was done. However, the jump to junit 5 resulted in command line tests no longer running which then highlighted this was not complete on a small number of tests. To ensure this type of thing never happens again, I've added jacoco to the mix. Each pom has jacoco coverage number set. The top one which is just pom is set to 100% for clarity reasons. The other three are set to their appropriate current code coverage (git module 81%, svn module has no tests, and main plugin at 77%). The svn module didn't actually need the setting as jacoco is skipped when no tests but presume we want to provision tests there at some point. We may want to go further here and add coveralls to show the coverage overall for the repo itself.
note: jacoco reports will get added, these are not shown from main site but that site needs some retooling to fluido and few other things so it looks modern rather than legacy apache LAF. [update: noticed this behavior locally to not show jacoco from the site directly was due to attach of descriptor only rather than full site run that is going to happen after merge with github action. I have updated to fluido locally though and it looks improved and also noting that main site on readme points to the old gh pages unless there is some other magic].