Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore test runs, add jacoco, and fix resulting broken tests #326

Merged
merged 8 commits into from
Mar 27, 2022

Conversation

hazendaz
Copy link
Collaborator

@hazendaz hazendaz commented Mar 27, 2022

This resolves shortcoming in junit 5 migration. I had initially wrote that code months ago and coming back to it only ran on command line. Outside of missing import changes in a few spots at that time, it appeared my work was done. However, the jump to junit 5 resulted in command line tests no longer running which then highlighted this was not complete on a small number of tests. To ensure this type of thing never happens again, I've added jacoco to the mix. Each pom has jacoco coverage number set. The top one which is just pom is set to 100% for clarity reasons. The other three are set to their appropriate current code coverage (git module 81%, svn module has no tests, and main plugin at 77%). The svn module didn't actually need the setting as jacoco is skipped when no tests but presume we want to provision tests there at some point. We may want to go further here and add coveralls to show the coverage overall for the repo itself.

note: jacoco reports will get added, these are not shown from main site but that site needs some retooling to fluido and few other things so it looks modern rather than legacy apache LAF. [update: noticed this behavior locally to not show jacoco from the site directly was due to attach of descriptor only rather than full site run that is going to happen after merge with github action. I have updated to fluido locally though and it looks improved and also noting that main site on readme points to the old gh pages unless there is some other magic].

@mathieucarbou
Copy link
Owner

thanks! let's merge. there is an automated github action that generates the snapshot site at each commit: https://mycila.carbou.me/license-maven-plugin/reports/4.2-SNAPSHOT/

@mathieucarbou mathieucarbou merged commit 5ed2a57 into mathieucarbou:master Mar 27, 2022
@mathieucarbou mathieucarbou added is:enhancement Enhancement to an existing feature in:build MLP build system (maven) labels Mar 28, 2022
@mathieucarbou mathieucarbou added this to the 4.2 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:build MLP build system (maven) is:enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants