Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Wrap if statements in brackets #322

Merged
merged 1 commit into from
Mar 26, 2022
Merged

[java] Wrap if statements in brackets #322

merged 1 commit into from
Mar 26, 2022

Conversation

hazendaz
Copy link
Collaborator

No description provided.

@hazendaz hazendaz assigned hazendaz and mathieucarbou and unassigned hazendaz Mar 25, 2022
mathieucarbou
mathieucarbou approved these changes Mar 26, 2022
View reviewed changes
Copy link
Owner

@mathieucarbou mathieucarbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Completely agree 👍

I didn't put the checkstyle and findbugs plugin in this project, but ideally we should.

Now that you did all this cleanup, it should be possible without a lot of impact.

@mathieucarbou mathieucarbou merged commit 0ac59d0 into mathieucarbou:master Mar 26, 2022
@mathieucarbou mathieucarbou added is:enhancement Enhancement to an existing feature in:build MLP build system (maven) labels Mar 28, 2022
@mathieucarbou mathieucarbou added this to the 4.2 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieucarbou mathieucarbou mathieucarbou approved these changes

Assignees

@mathieucarbou mathieucarbou

Labels
in:build MLP build system (maven) is:enhancement Enhancement to an existing feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@hazendaz @mathieucarbou